cli/compose cleanup - remove the old loading system#30521
Merged
LK4D4 merged 1 commit intomoby:mastermoby/moby:masterfrom Jan 30, 2017
dnephin:cleanup-compose-loaderdnephin/docker:cleanup-compose-loaderCopy head branch name to clipboard
Merged
cli/compose cleanup - remove the old loading system#30521LK4D4 merged 1 commit intomoby:mastermoby/moby:masterfrom dnephin:cleanup-compose-loaderdnephin/docker:cleanup-compose-loaderCopy head branch name to clipboard
cli/compose cleanup - remove the old loading system#30521LK4D4 merged 1 commit intomoby:mastermoby/moby:masterfrom
dnephin:cleanup-compose-loaderdnephin/docker:cleanup-compose-loaderCopy head branch name to clipboard
Conversation
The original Compose config loading used the `compose` tag, which was replaced by mapstructure. Some fields were left on the old tag. This commit removes the old tag and uses types and mapstructure. Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
`cli/compose` cleanup - remove the old loading system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original Compose config loading used the
composestruct tag, which was replaced bymapstructure. Some fields were left on the old tag as part of the transition. This PR removes the old tag and uses types andmapstructurefor config loading.cc @vdemeester