Add error checking for hostPort range#30103
Merged
cpuguy83 merged 1 commit intomoby:mastermoby/moby:masterfrom Jan 14, 2017
tabboud:29961-add-error-checkingtabboud/docker:29961-add-error-checkingCopy head branch name to clipboard
Merged
Add error checking for hostPort range#30103cpuguy83 merged 1 commit intomoby:mastermoby/moby:masterfrom tabboud:29961-add-error-checkingtabboud/docker:29961-add-error-checkingCopy head branch name to clipboard
cpuguy83 merged 1 commit intomoby:mastermoby/moby:masterfrom
tabboud:29961-add-error-checkingtabboud/docker:29961-add-error-checkingCopy head branch name to clipboard
Conversation
This fix catches the case where there is a single container port
and a dynamic host port and will fail out gracefully
Example docker-compose.yml snippet:
port:
ports:
- "8091-8093:8091"
- "80:8080"
Signed-off-by: Tony Abboud <tdabboud@hotmail.com>
113d001 to
135f8f9
Compare
|
LGTM ping @dnephin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #29961
Signed-off-by: Tony Abboud tdabboud@hotmail.com
- What I did
Add error handling for the case where there is a single container port
and a dynamic host port
Example docker-compose.yml snippet:
port:
ports:
- "8091-8093:8091"
- "80:8080"
- How I did it
Checked the return error from
strconv.ParseUint()and handled the error if the given hostPort is not an empty string, which means that the hostPort is either a range or an invalid number- How to verify it
- Description for the changelog
Add error handling for hostPorts when converting a Port to a PortConfig
- A picture of a cute animal (not mandatory but encouraged)