MRG: roc_auc when y not in [0, 1] #3874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.58% (diff: 100%)
|
agramfort
reviewed
Dec 22, 2016
| if scoring is not None: | ||
| if hasattr(scoring, '_score_func'): | ||
| if hasattr(scoring._score_func, '__name__'): | ||
| if scoring._score_func.__name__ == 'roc_auc_score': |
There was a problem hiding this comment.
can you avoid the 4 if and use just one with some 'and'
thx
There was a problem hiding this comment.
I had done this with '&' and it didn't work, but hadn't thought it'd differ from 'and'. Learn something everyday ..
agramfort
reviewed
Dec 22, 2016
| # -- 2 class problem not in [0, 1] | ||
| y = np.arange(len(X)) % 2 + 1 | ||
| gl.fit(X, y) | ||
| gl.score(X, y) |
There was a problem hiding this comment.
can you check that the results are correct?
here you just check it runs
|
thx @kingjr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error when scoring='roc_auc' and y is not in [0, 1]:
Should be ultimately solved in scikit-learn/scikit-learn#6874
Replaces #3717, Closes #3697