Depythonize ruby + tiny improvements #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 1, 2021 20:11
Some other rubyists may disagree with my version, & i encourage them to fix it. However, it's definitely more rubyish than the previous version.
Owner
|
Thanks for the PR, @tiosgz. I forgot this repo even exists. Haha. Your changes look fine. In order for me to merge, you're going to have to update the README as well since the code is in there as well. |
Author
I have done that, & have even fixed this omission from #16. If you want also the shebangs to be there, let me know; i didn’t consider them important as they don’t make the README executable in any way. |
Owner
|
My bad. I missed that. Merging now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.
Even during the depythonizing the one way/more ways factor played a role – it took me a while to figure out i want to use
1.upto 6because it’s the best readable variant IMO 😉Feel free to raise complaints.