Refactoring ruby example to use ternary operator #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As someone who writes Ruby regularly, the use of a return statement with a same-line if statement followed by a second default return seemed verbose and less readable. Plus, a one line ternary statement seems like a pretty good example of Ruby being Perl-like and a little unnecessarily complex to read for coders who don’t live with it every day.
Owner
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As someone who writes Ruby regularly, the use of a return statement
with a same-line if statement followed by a second default return
seemed verbose and less readable.
Plus, a one line ternary statement seems like a pretty good example of
Ruby being Perl-like and a little unnecessarily complex to read for
coders who don’t live with it every day.
Close #9