Add Component Node for C4 model#1000
Open
jseop-lim wants to merge 2 commits intomingrammer:mastermingrammer/diagrams:masterfrom
jseop-lim:feature/c4-model-componentjseop-lim/diagrams:feature/c4-model-componentCopy head branch name to clipboard
Open
Add Component Node for C4 model#1000jseop-lim wants to merge 2 commits intomingrammer:mastermingrammer/diagrams:masterfrom jseop-lim:feature/c4-model-componentjseop-lim/diagrams:feature/c4-model-componentCopy head branch name to clipboard
jseop-lim wants to merge 2 commits intomingrammer:mastermingrammer/diagrams:masterfrom
jseop-lim:feature/c4-model-componentjseop-lim/diagrams:feature/c4-model-componentCopy head branch name to clipboard
Conversation
janstice
reviewed
May 12, 2025
|
|
||
|
|
||
| def Component(name, technology="", description="", **kwargs): | ||
| container_attributes = { |
There was a problem hiding this comment.
semi-nit: Could probably edit to component_atributes here
|
and +1 to this idea (your solution is pretty much what I have in my code) - do you think it's worth making a Container that can act as a boundary too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a new feature: the addition of C4 model Component nodes.
Previously, there were no Component nodes available for creating Component diagrams at the C4 model Level 3. This enhancement allows for the creation of Component diagrams, filling an important gap in the current functionality.
Changes
Testing
Request for Feedback
Impact
This enhancement should have no breaking changes for existing users. It is designed to be an additive feature that extends the capabilities without affecting current functionalities.
Example Usage
Code for drawing C4 model examples:
It produces a diagram like this: