Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b0747a9

Browse filesBrowse files
author
Jon Wayne Parrott
authored
Update monitoring samples to use more descriptive variable names (GoogleCloudPlatform#1058)
Change-Id: I648cd686a10399b7f92373fdcd48708396fd7140
1 parent c35eef7 commit b0747a9
Copy full SHA for b0747a9

File tree

Expand file treeCollapse file tree

1 file changed

+15
-15
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+15
-15
lines changed

‎monitoring/api/v3/cloud-client/snippets.py

Copy file name to clipboardExpand all lines: monitoring/api/v3/cloud-client/snippets.py
+15-15Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@ def create_metric_descriptor():
2929
# [END create_metric_descriptor]
3030

3131

32-
def delete_metric_descriptor(descriptor):
32+
def delete_metric_descriptor(descriptor_name):
3333
# [START delete_metric_descriptor]
3434
client = monitoring.Client()
35-
descriptor = client.metric_descriptor(
36-
descriptor
37-
)
35+
36+
descriptor = client.metric_descriptor(descriptor_name)
3837
descriptor.delete()
39-
print('Deleted metric descriptor.')
38+
39+
print('Deleted metric descriptor {}.'.format(descriptor_name))
4040
# [END delete_metric_descriptor]
4141

4242

@@ -119,17 +119,17 @@ def list_monitored_resources():
119119
# [END list_monitored_resources]
120120

121121

122-
def get_monitored_resource_descriptor(type_):
122+
def get_monitored_resource_descriptor(resource_type_name):
123123
# [START get_monitored_resources]
124124
client = monitoring.Client()
125-
print(client.fetch_resource_descriptor(type_))
125+
print(client.fetch_resource_descriptor(resource_type_name))
126126
# [END get_monitored_resources]
127127

128128

129-
def get_metric_descriptor(type_):
129+
def get_metric_descriptor(metric_type_name):
130130
# [START get_metric_descriptor]
131131
client = monitoring.Client()
132-
print(client.fetch_metric_descriptor(type_))
132+
print(client.fetch_metric_descriptor(metric_type_name))
133133
# [END get_metric_descriptor]
134134

135135

@@ -155,7 +155,7 @@ def get_metric_descriptor(type_):
155155
)
156156

157157
get_metric_descriptor_parser.add_argument(
158-
'--metric',
158+
'--metric-type-name',
159159
help='The metric type of the metric descriptor to see details about.',
160160
required=True
161161
)
@@ -166,7 +166,7 @@ def get_metric_descriptor(type_):
166166
)
167167

168168
delete_metric_descriptor_parser.add_argument(
169-
'--metric',
169+
'--metric-descriptor-name',
170170
help='Metric descriptor to delete',
171171
required=True
172172
)
@@ -182,7 +182,7 @@ def get_metric_descriptor(type_):
182182
)
183183

184184
get_resource_parser.add_argument(
185-
'--resource',
185+
'--resource-type-name',
186186
help='Monitored resource to view more information about.',
187187
required=True
188188
)
@@ -219,13 +219,13 @@ def get_metric_descriptor(type_):
219219
if args.command == 'list-metric-descriptors':
220220
list_metric_descriptors()
221221
if args.command == 'get-metric-descriptor':
222-
get_metric_descriptor(args.metric)
222+
get_metric_descriptor(args.metric_type_name)
223223
if args.command == 'delete-metric-descriptor':
224-
delete_metric_descriptor(args.metric)
224+
delete_metric_descriptor(args.metric_descriptor_name)
225225
if args.command == 'list-resources':
226226
list_monitored_resources()
227227
if args.command == 'get-resource':
228-
get_monitored_resource_descriptor(args.resource)
228+
get_monitored_resource_descriptor(args.resource_type_name)
229229
if args.command == 'write-time-series':
230230
write_time_series()
231231
if args.command == 'list-time-series':

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.