Drop virtiofsd reload #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was not working anyway
There was a problem hiding this comment.
Pull Request Overview
This PR removes non-functional reload functionality from the virtiofsd service. The reload command was not working as intended, so both the reload script definition and its systemd service configuration have been removed.
- Removed the
virtiofsd-reloadscript that attempted to reload supervisord configuration - Removed the
ExecReloaddirective from the systemd service configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nixos-modules/microvm/virtiofsd/default.nix | Removed the virtiofsd-reload script definition that was not functioning correctly |
| nixos-modules/host/default.nix | Removed the ExecReload service configuration that referenced the now-deleted reload script |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was not working anyway
Closes #405