Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Adding initial thoughts on Kiota JS for Graph#558

Merged
sebastienlevert merged 13 commits intomicrosoftgraph:devmicrosoftgraph/msgraph-sdk-javascript:devfrom
sebastienlevert:sebastienlevert/v4-js-e2esebastienlevert/msgraph-sdk-javascript:sebastienlevert/v4-js-e2eCopy head branch name to clipboard
Feb 15, 2022
Merged

Adding initial thoughts on Kiota JS for Graph#558
sebastienlevert merged 13 commits intomicrosoftgraph:devmicrosoftgraph/msgraph-sdk-javascript:devfrom
sebastienlevert:sebastienlevert/v4-js-e2esebastienlevert/msgraph-sdk-javascript:sebastienlevert/v4-js-e2eCopy head branch name to clipboard

Conversation

@sebastienlevert
Copy link
Contributor

Design specs for the kiota generated version of the JS SDK.

@sebastienlevert
Copy link
Contributor Author

Before we go any further, I wanted to know if this is helpful and hear from both of you @baywet and @nikithauc. It's absolutely a WIP but I'd love to get early feedback! That will help with defining what is required to make technical decisions! Thanks!

design/kiota-e2e.md Outdated Show resolved Hide resolved
design/kiota-e2e.md Show resolved Hide resolved
design/kiota-e2e.md Outdated Show resolved Hide resolved
design/kiota-e2e.md Outdated Show resolved Hide resolved
baywet
baywet previously requested changes Jan 17, 2022
design/kiota-e2e.md Outdated Show resolved Hide resolved
design/kiota-e2e.md Outdated Show resolved Hide resolved
design/kiota-e2e.md Outdated Show resolved Hide resolved
design/kiota-e2e.md Show resolved Hide resolved
design/kiota-e2e.md Outdated Show resolved Hide resolved
@nikithauc
Copy link
Contributor

This could be added in this document too

Tasks constructors such as PageIterator and LargeFileUpload tasks should accept both GraphServiceClient and GraphCoreClient

// both should work
const pageIterator = PageIterator(GraphServiceClient, options);
or
const pageIterator = PageIterator(GraphCoreClient, options);

design/kiota-e2e.md Outdated Show resolved Hide resolved
design/kiota-e2e.md Outdated Show resolved Hide resolved
design/kiota-e2e.md Show resolved Hide resolved
design/kiota-e2e.md Show resolved Hide resolved
@sebastienlevert sebastienlevert marked this pull request as ready for review February 15, 2022 20:10
@sebastienlevert sebastienlevert dismissed baywet’s stale review February 15, 2022 20:13

We will be merging the spec in the and then have smaller increments. Will help with the overall discussion!

@sebastienlevert sebastienlevert merged commit f4939cd into microsoftgraph:dev Feb 15, 2022
@sebastienlevert sebastienlevert deleted the sebastienlevert/v4-js-e2e branch February 15, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.