Adding CustomHosts options#453
Merged
nikithauc merged 7 commits intodevmicrosoftgraph/msgraph-sdk-javascript:devfrom Jun 1, 2021
nikithauc/custom-urlsmicrosoftgraph/msgraph-sdk-javascript:nikithauc/custom-urlsCopy head branch name to clipboard
Merged
Adding CustomHosts options#453nikithauc merged 7 commits intodevmicrosoftgraph/msgraph-sdk-javascript:devfrom nikithauc/custom-urlsmicrosoftgraph/msgraph-sdk-javascript:nikithauc/custom-urlsCopy head branch name to clipboard
CustomHosts options#453nikithauc merged 7 commits intodevmicrosoftgraph/msgraph-sdk-javascript:devfrom
nikithauc/custom-urlsmicrosoftgraph/msgraph-sdk-javascript:nikithauc/custom-urlsCopy head branch name to clipboard
Conversation
baywet
previously approved these changes
May 17, 2021
MIchaelMainer
approved these changes
Jun 1, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to - https://github.com/microsoftgraph/msgraph-sdk-design/pull/45/files
Certain workloads error out when an unexpected header is present in the request.
Example -
In case of
LargeFileUploadTaskin JS library, the upload is as follows:The middleware appends request headers which are meant for the Graph API.
Outlook, an error was caused because ofAuthorizationheader.sdkversiontelemetry headerThe solution for this is to add a check if the request URL is a Graph endpoint and not send headers to
UPLOAD_URL.Adding the headers only for Graph endpoints ignores the case where the developer might have their own test endpoints.
This PR contains changes to allow developers to provide custom endpoints and update our conditions to modify request headers.