Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Updated GraphRequest.ts for .count() scenario#243

Merged
krototype merged 1 commit intodevmicrosoftgraph/msgraph-sdk-javascript:devfrom
abhsriva/update-countmicrosoftgraph/msgraph-sdk-javascript:abhsriva/update-countCopy head branch name to clipboard
Oct 25, 2019
Merged

Updated GraphRequest.ts for .count() scenario#243
krototype merged 1 commit intodevmicrosoftgraph/msgraph-sdk-javascript:devfrom
abhsriva/update-countmicrosoftgraph/msgraph-sdk-javascript:abhsriva/update-countCopy head branch name to clipboard

Conversation

@krototype
Copy link
Contributor

Updated GraphRequest.ts to handle .count() when no parameter is specified

Summary

When the query parameter .count() didn't have any parameter passed, it used to give an error.
So adding the default value as false for this case (this is according to the graph behavior).

Closing issues

#241

Fixes #241

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Updated GraphRequest.ts to handle .count() when no parameter is specified
@krototype krototype merged commit b9a66b4 into dev Oct 25, 2019
@krototype krototype deleted the abhsriva/update-count branch October 25, 2019 05:15
@krototype krototype restored the abhsriva/update-count branch October 25, 2019 06:54
@nikithauc nikithauc deleted the abhsriva/update-count branch September 2, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default count() param to true

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.