Remove node 12 test in build#1159
Merged
nikithauc merged 1 commit intomainmicrosoftgraph/msgraph-sdk-javascript:mainfrom Jan 30, 2023
nikithauc/remove-node12microsoftgraph/msgraph-sdk-javascript:nikithauc/remove-node12Copy head branch name to clipboard
Merged
Remove node 12 test in build#1159nikithauc merged 1 commit intomainmicrosoftgraph/msgraph-sdk-javascript:mainfrom nikithauc/remove-node12microsoftgraph/msgraph-sdk-javascript:nikithauc/remove-node12Copy head branch name to clipboard
nikithauc merged 1 commit intomainmicrosoftgraph/msgraph-sdk-javascript:mainfrom
nikithauc/remove-node12microsoftgraph/msgraph-sdk-javascript:nikithauc/remove-node12Copy head branch name to clipboard
Conversation
gavinbarron
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 12 is failing the prod build. https://microsoftgraph.visualstudio.com/Graph%20Developer%20Experiences/_build/results?buildId=104090&view=logs&j=6ee93217-dd90-5523-3164-ee16656da314&t=ccedd99f-4017-5313-45ba-56d914a47e80
This failure has already been handled in the CI validation https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/dev/.github/workflows/ci_validation.yml
Removing the node 12 testing in the prod build yaml as it already done in the CI validation.