Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Mocha version update#1131

Merged
nikithauc merged 4 commits intodevmicrosoftgraph/msgraph-sdk-javascript:devfrom
nikithauc/mocha-updatemicrosoftgraph/msgraph-sdk-javascript:nikithauc/mocha-updateCopy head branch name to clipboard
Jan 11, 2023
Merged

Mocha version update#1131
nikithauc merged 4 commits intodevmicrosoftgraph/msgraph-sdk-javascript:devfrom
nikithauc/mocha-updatemicrosoftgraph/msgraph-sdk-javascript:nikithauc/mocha-updateCopy head branch name to clipboard

Conversation

@nikithauc
Copy link
Contributor

  • Taking the latest version of mocha with is not compatible with esm library.
  • Added a simple tiny project to test if a ESM project with "type:module" compiles fine with the Graph JS library.

@nikithauc nikithauc requested a review from gavinbarron January 10, 2023 22:33
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikithauc nikithauc merged commit cd0ad63 into dev Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.