feature/version-increment#89
Merged
baywet merged 6 commits intodevmicrosoftgraph/msgraph-sdk-java-core:devfrom Dec 1, 2020
feature/version-incrementmicrosoftgraph/msgraph-sdk-java-core:feature/version-incrementCopy head branch name to clipboard
Merged
feature/version-increment#89baywet merged 6 commits intodevmicrosoftgraph/msgraph-sdk-java-core:devfrom feature/version-incrementmicrosoftgraph/msgraph-sdk-java-core:feature/version-incrementCopy head branch name to clipboard
baywet merged 6 commits intodevmicrosoftgraph/msgraph-sdk-java-core:devfrom
feature/version-incrementmicrosoftgraph/msgraph-sdk-java-core:feature/version-incrementCopy head branch name to clipboard
Conversation
This was referenced Nov 25, 2020
zengin
suggested changes
Nov 30, 2020
Contributor
zengin
left a comment
There was a problem hiding this comment.
please replace version regex parsing with built-in [version] cast.
zengin
approved these changes
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #36