- adds defensive programming for json parsing#70
Merged
baywet merged 5 commits intodevmicrosoftgraph/msgraph-sdk-java-core:devfrom Sep 14, 2020
bugfix/json-parsing-defensivemicrosoftgraph/msgraph-sdk-java-core:bugfix/json-parsing-defensiveCopy head branch name to clipboard
Merged
- adds defensive programming for json parsing#70baywet merged 5 commits intodevmicrosoftgraph/msgraph-sdk-java-core:devfrom bugfix/json-parsing-defensivemicrosoftgraph/msgraph-sdk-java-core:bugfix/json-parsing-defensiveCopy head branch name to clipboard
baywet merged 5 commits intodevmicrosoftgraph/msgraph-sdk-java-core:devfrom
bugfix/json-parsing-defensivemicrosoftgraph/msgraph-sdk-java-core:bugfix/json-parsing-defensiveCopy head branch name to clipboard
Conversation
zengin
reviewed
Sep 11, 2020
src/main/java/com/microsoft/graph/content/MSBatchRequestContent.java
Outdated
Show resolved
Hide resolved
zengin
reviewed
Sep 11, 2020
src/main/java/com/microsoft/graph/content/MSBatchResponseContent.java
Outdated
Show resolved
Hide resolved
zengin
approved these changes
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writing my unit tests I noticed some defensive programing was missing which could result in NPE's and/or in cast exceptions from the JSON lib