Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

- fixes an issue where maven version would not be compared#54

Merged
baywet merged 2 commits intodevmicrosoftgraph/msgraph-sdk-java-core:devfrom
bugfix/versionvalidation-inconsitentmicrosoftgraph/msgraph-sdk-java-core:bugfix/versionvalidation-inconsitentCopy head branch name to clipboard
Aug 31, 2020
Merged

- fixes an issue where maven version would not be compared#54
baywet merged 2 commits intodevmicrosoftgraph/msgraph-sdk-java-core:devfrom
bugfix/versionvalidation-inconsitentmicrosoftgraph/msgraph-sdk-java-core:bugfix/versionvalidation-inconsitentCopy head branch name to clipboard

Conversation

@baywet
Copy link
Member

@baywet baywet commented Aug 31, 2020

Changes proposed in this pull request

  • fixes an issue where version comparison would be inconsistent
  • adds defaults values for the version comparison script to reduce complexity for users

Other links

@baywet baywet requested review from MIchaelMainer and zengin August 31, 2020 13:31
@baywet baywet mentioned this pull request Aug 31, 2020
@baywet baywet added this to the 1.0.2 milestone Aug 31, 2020
Scripts/validateMavenVersion.ps1 Outdated Show resolved Hide resolved
Scripts/validateMavenVersion.ps1 Outdated Show resolved Hide resolved
Co-authored-by: Mustafa Zengin <muzengin@microsoft.com>
@baywet baywet requested a review from zengin August 31, 2020 15:21
@baywet baywet merged commit 8adaed2 into dev Aug 31, 2020
@baywet baywet deleted the bugfix/versionvalidation-inconsitent branch August 31, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.