Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Updated telemetry header to include java version at runtime #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NakulSabharwal merged 2 commits into from
Aug 28, 2019
Merged

Updated telemetry header to include java version at runtime #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bedea6
Updated telemetry header to include java runtime version
Aug 28, 2019
0311255
Updated patch version
Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ mavenGroupId = com.microsoft.graph
mavenArtifactId = microsoft-graph-core
mavenMajorVersion = 1
mavenMinorVersion = 0
mavenPatchVersion = 0
mavenPatchVersion = 1
mavenArtifactSuffix =
nightliesUrl = http://dl.bintray.com/MicrosoftGraph/Maven

Expand Down
4 changes: 2 additions & 2 deletions 4 readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ repository {

dependency {
// Include the sdk as a dependency
compile('com.microsoft.graph:microsoft-graph-core:1.0.0')
compile('com.microsoft.graph:microsoft-graph-core:1.0.1')
}
```

Expand All @@ -29,7 +29,7 @@ Add the dependency in `dependencies` in pom.xml
<dependency>
<groupId>com.microsoft.graph</groupId>
<artifactId>microsoft-graph-core</artifactId>
<version>1.0.0</version>
<version>1.0.1</version>
</dependency>
```

Expand Down
6 changes: 4 additions & 2 deletions 6 src/main/java/com/microsoft/graph/httpcore/TelemetryHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@
public class TelemetryHandler implements Interceptor{

public static final String SDK_VERSION = "SdkVersion";
public static final String VERSION = "v1.0.0";
public static final String VERSION = "v1.0.1";
public static final String GRAPH_VERSION_PREFIX = "graph-java-core";
public static final String JAVA_VERSION_PREFIX = "java";
public static final String CLIENT_REQUEST_ID = "client-request-id";

@Override
Expand All @@ -25,7 +26,8 @@ public Response intercept(Chain chain) throws IOException {
telemetryOptions = new TelemetryOptions();

String featureUsage = "(featureUsage=" + telemetryOptions.getFeatureUsage() + ")";
String sdkversion_value = GRAPH_VERSION_PREFIX + "/" + VERSION + " " + featureUsage;
String javaVersion = System.getProperty("java.version");
String sdkversion_value = GRAPH_VERSION_PREFIX + "/" + VERSION + " " + featureUsage + " " + JAVA_VERSION_PREFIX + "/" + javaVersion;
telemetryAddedBuilder.addHeader(SDK_VERSION, sdkversion_value);

if(request.header(CLIENT_REQUEST_ID) == null) {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.