Add middlewares and BatchRequest capability to core library#2
Merged
deepak2016 merged 19 commits intodevmicrosoftgraph/msgraph-sdk-java-core:devfrom Jan 21, 2019
Merged
Add middlewares and BatchRequest capability to core library#2deepak2016 merged 19 commits intodevmicrosoftgraph/msgraph-sdk-java-core:devfrom
deepak2016 merged 19 commits intodevmicrosoftgraph/msgraph-sdk-java-core:devfrom
Conversation
…ch request content
BatchRequestContent - parametrize object creation of collection classes.
src/main/java/com/microsoft/graph/httpcore/AuthenticationHandler.java
Outdated
Show resolved
Hide resolved
dadheech115
reviewed
Jan 21, 2019
src/main/java/com/microsoft/graph/content/MSBatchRequestContent.java
Outdated
Show resolved
Hide resolved
dadheech115
reviewed
Jan 21, 2019
src/main/java/com/microsoft/graph/httpcore/IAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
dadheech115
reviewed
Jan 21, 2019
dadheech115
reviewed
Jan 21, 2019
src/test/java/com/microsoft/graph/content/MSBatchRequestContentTest.java
Show resolved
Hide resolved
…ase code coverage to more than 90%
dadheech115
approved these changes
Jan 21, 2019
| import org.json.simple.JSONObject; | ||
| import org.json.simple.JSONValue; | ||
|
|
||
| public class MSBatchRequestContent { |
There was a problem hiding this comment.
What is the reason for the MS prefix? If a prefix is necessary, would "Graph" not be a better prefix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BatchRequestContent, BatchRequestStep and BatchResponseContent classes, along with middleware files.
Added Middlewares:
AuthenticationHandler
RetryHandler
RedirectHandler