Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Generated v1.0 models and request builders using Typewriter#666

Merged
baywet merged 2 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom
v1.0/pipelinebuild/40643microsoftgraph/msgraph-sdk-java:v1.0/pipelinebuild/40643Copy head branch name to clipboard
Feb 16, 2021
Merged

Generated v1.0 models and request builders using Typewriter#666
baywet merged 2 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom
v1.0/pipelinebuild/40643microsoftgraph/msgraph-sdk-java:v1.0/pipelinebuild/40643Copy head branch name to clipboard

Conversation

@github-actions
Copy link
Contributor

This pull request was automatically created by the GitHub Action, create pull request.

The commit hash is 6bebf8b.

Important Check for unexpected deletions or changes in this PR.

cc: @darrelmiller

@baywet baywet force-pushed the v1.0/pipelinebuild/40643 branch from b4ca154 to ac5de2d Compare February 16, 2021 13:26
@baywet
Copy link
Member

baywet commented Feb 16, 2021

@zengin I'd like your confirmation please before I merge that one. It's just comments changes but it looks like the pipeline copy on @MIchaelMainer ADO instance is still active, see the history https://github.com/microsoftgraph/msgraph-metadata/commits/master

@zengin
Copy link
Contributor

zengin commented Feb 16, 2021

@baywet yes we should turn off the metadata update as well, but I don't have access to @MIchaelMainer's instance. The good news is that the real pipeline is running after Michael's, so the data here should be good in case different logic is running there. The only side effect seems to be to the history of msgraph-metadata repo, which shouldn't be big deal until Michael is back.

@baywet
Copy link
Member

baywet commented Feb 16, 2021

thanks for double checking! merging.
BTW we didn't get beta updates, I'm not sure whether it was because no changes were published or because something else is wrong?

@baywet baywet merged commit 31121a7 into dev Feb 16, 2021
@baywet baywet deleted the v1.0/pipelinebuild/40643 branch February 16, 2021 16:56
@baywet baywet added this to the 2.8.0 milestone Feb 16, 2021
@zengin
Copy link
Contributor

zengin commented Feb 16, 2021

@baywet, there is an SDK bug that blocks beta generation. I have a fix, the PR should be out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.