Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Generated v1.0 models and request builders using Typewriter#658

Merged
baywet merged 4 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom
v1.0/pipelinebuild/39906microsoftgraph/msgraph-sdk-java:v1.0/pipelinebuild/39906Copy head branch name to clipboard
Feb 10, 2021
Merged

Generated v1.0 models and request builders using Typewriter#658
baywet merged 4 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom
v1.0/pipelinebuild/39906microsoftgraph/msgraph-sdk-java:v1.0/pipelinebuild/39906Copy head branch name to clipboard

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 9, 2021

This pull request was automatically created by the GitHub Action, create pull request.

The commit hash is 78ccd58.

Important Check for unexpected deletions or changes in this PR.

cc: @darrelmiller

@baywet
Copy link
Member

baywet commented Feb 9, 2021

@MIchaelMainer @zengin the older pipeline seems to still be active given the number in this branch. Did we forget to disable something?

@zengin
Copy link
Contributor

zengin commented Feb 9, 2021

@baywet this is the result of my full run on main.

@baywet
Copy link
Member

baywet commented Feb 9, 2021

But should we have a difference given we already merged #655 ? Or was the metadata updated in between the two?

@zengin
Copy link
Contributor

zengin commented Feb 10, 2021

That one was running in @MIchaelMainer's own ADO instance (small build number: 50). It is hard to tell for me what particular code that ADO instance is running. The correct end result should be this one.

@baywet
Copy link
Member

baywet commented Feb 10, 2021

That explains a lot! The other one was only a comments change. I'll revert minor bump and bump patch instead on this one tomorrow and we'll call it a day.

@baywet baywet force-pushed the v1.0/pipelinebuild/39906 branch from c7dbf5e to e1f2b7b Compare February 10, 2021 15:19
@baywet baywet merged commit 9472f99 into dev Feb 10, 2021
@baywet baywet deleted the v1.0/pipelinebuild/39906 branch February 10, 2021 15:54
@baywet
Copy link
Member

baywet commented Feb 10, 2021

@zengin Because this update added a lot of changes, using the typesummary was fastidious.
I used pkgdiff instead, it works well for java on WSL. Due to how the diff are structured, we could imagine parsing the outcome files and automate the regression check. What do you think?
github.zip

@zengin
Copy link
Contributor

zengin commented Feb 10, 2021

@baywet, I like it. It looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.