Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

removes duplicate configuration from core #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 3 commits into from
Nov 30, 2020
Merged

removes duplicate configuration from core #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84257ee
- removes deprecated connection configuration
baywet Nov 27, 2020
74f62b3
- updates types summary
Nov 27, 2020
594a7ea
- lints
baywet Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
203 changes: 0 additions & 203 deletions 203 src/main/java/com/microsoft/graph/core/DefaultConnectionConfig.java
View file
Open in desktop

This file was deleted.

25 changes: 1 addition & 24 deletions 25 src/main/java/com/microsoft/graph/core/GraphServiceClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@

import com.microsoft.graph.httpcore.HttpClients;
import com.microsoft.graph.httpcore.ICoreAuthenticationProvider;
import com.microsoft.graph.core.DefaultConnectionConfig;
import com.microsoft.graph.core.IConnectionConfig;
import com.microsoft.graph.concurrency.DefaultExecutors;
import com.microsoft.graph.logger.*;
import com.google.gson.JsonObject;
Expand Down Expand Up @@ -85,7 +83,6 @@ public static final class Builder<httpClientType> {
private IExecutors executors;
private ILogger logger;
private httpClientType httpClient;
private IConnectionConfig connConfig;
private ICoreAuthenticationProvider auth;

private ICoreAuthenticationProvider getAuth() {
Expand All @@ -95,13 +92,6 @@ private ICoreAuthenticationProvider getAuth() {
return auth;
}
}
private IConnectionConfig getConnectionConfig() {
if(connConfig == null) {
return new DefaultConnectionConfig() {};
} else {
return connConfig;
}
}
private ILogger getLogger() {
if(logger == null) {
return new DefaultLogger();
Expand Down Expand Up @@ -133,7 +123,7 @@ private httpClientType getHttpClient() {
}
private IHttpProvider getHttpProvider() {
if(httpProvider == null) {
return new CoreHttpProvider(getSerializer(), getExecutors(), getLogger(), (OkHttpClient)getHttpClient(), getConnectionConfig());
return new CoreHttpProvider(getSerializer(), getExecutors(), getLogger(), (OkHttpClient)getHttpClient());
} else {
return httpProvider;
}
Expand Down Expand Up @@ -209,19 +199,6 @@ public Builder<httpClientType> httpClient(@Nonnull final httpClientType client)
return this;
}

/**
* Sets the connection configuration
*
* @param config connection configuration
*
* @return the instance of this builder
*/
@Nonnull
public Builder<httpClientType> connectionConfig(@Nonnull final IConnectionConfig config) {
checkNotNull(config, "config");
this.connConfig = config;
return this;
}
/**
* Sets the authentication provider
*
Expand Down
134 changes: 0 additions & 134 deletions 134 src/main/java/com/microsoft/graph/core/IConnectionConfig.java
View file
Open in desktop

This file was deleted.

Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.