bugfix/service-wrong-casing#531
Merged
baywet merged 2 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom Oct 7, 2020
bugfix/service-wrong-casingmicrosoftgraph/msgraph-sdk-java:bugfix/service-wrong-casingCopy head branch name to clipboard
Merged
bugfix/service-wrong-casing#531baywet merged 2 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom bugfix/service-wrong-casingmicrosoftgraph/msgraph-sdk-java:bugfix/service-wrong-casingCopy head branch name to clipboard
baywet merged 2 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom
bugfix/service-wrong-casingmicrosoftgraph/msgraph-sdk-java:bugfix/service-wrong-casingCopy head branch name to clipboard
Conversation
This was referenced Oct 7, 2020
zengin
approved these changes
Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #529
Adds support for pascal case in deserialization as the service sometimes replies with that casing instead of dromedary case.
Note: I've also considered adding a custom deserializer, but it results into a complex implementation with the other deserializers we have.
Changing the naming policy would have replaced the policy, causing other issues down the line.
Implementing a naming strategy would have impacted the serialization as well.