Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

buildRequest varargs overload #8

Copy link
Copy link
@davidmoten

Description

@davidmoten
Issue body actions

This is a very common pattern in the generated code:
public interface IBaseMessageCollectionRequestBuilder extends IRequestBuilder {

IMessageCollectionRequest buildRequest();

IMessageCollectionRequest buildRequest(final java.util.List<Option> requestOptions);

...
Firstly the final keyword doesn't do anything and can be chucked.
Secondly, a varargs overload would make life easier for the client:
IMessageCollectionRequest buildRequest(Option... requestOptions);
Without the varargs overload I have to do this (using guava dependency as well):
.buildRequest(Lists.newArrayList(new QueryOption("filter", "isRead eq false")));
I would like to do:
.buildRequest(new QueryOption("filter", "isRead eq false"));
AB#6039

Reactions are currently unavailable

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.