Fix OData methods with OData primitive return type#300
Merged
MIchaelMainer merged 9 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom Oct 6, 2020
fix/methodWithODataPrimitiveReturnValuemicrosoftgraph/MSGraph-SDK-Code-Generator:fix/methodWithODataPrimitiveReturnValueCopy head branch name to clipboard
Merged
Fix OData methods with OData primitive return type#300MIchaelMainer merged 9 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom fix/methodWithODataPrimitiveReturnValuemicrosoftgraph/MSGraph-SDK-Code-Generator:fix/methodWithODataPrimitiveReturnValueCopy head branch name to clipboard
MIchaelMainer merged 9 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom
fix/methodWithODataPrimitiveReturnValuemicrosoftgraph/MSGraph-SDK-Code-Generator:fix/methodWithODataPrimitiveReturnValueCopy head branch name to clipboard
Conversation
ODate primitives method return types are returned in an object. We weren't handling the object which resulted in serialization exceptions. modified: Templates/CSharp/Base/SharedCSharp.template.tt modified: Templates/CSharp/Requests/MethodRequest.cs.tt
zengin
previously approved these changes
Sep 25, 2020
zengin
previously approved these changes
Sep 30, 2020
zengin
previously approved these changes
Oct 6, 2020
| // GetMethodRequestPrimitiveReturnTypeString() in SharedCSharp. | ||
| var tempReturnType = GetMethodRequestPrimitiveReturnTypeString(returnEntityType); | ||
|
|
||
| // These magic strings represent types in M.G.C. If the return |
Contributor
There was a problem hiding this comment.
nit: What it represents is clear from the context, but having it full string may help in a future search for this comment.
Suggested change
| // These magic strings represent types in M.G.C. If the return | |
| // These magic strings represent types in Microsoft.Graph.Core. If the return |
nikithauc
previously approved these changes
Oct 6, 2020
zengin
approved these changes
Oct 6, 2020
MIchaelMainer
added a commit
that referenced
this pull request
Oct 6, 2020
ODate primitives method return types are returned in an object.
We weren't handling the object which resulted in serialization
exceptions.
modified: Templates/CSharp/Base/SharedCSharp.template.tt
modified: Templates/CSharp/Requests/MethodRequest.cs.tt
modified: Templates/CSharp/Requests/IMethodRequest.cs.tt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ODate primitives method return types are returned in an object.
We weren't handling the object which resulted in serialization
exceptions.
Generated code differences
microsoftgraph/msgraph-beta-sdk-dotnet#160
microsoftgraph/msgraph-sdk-dotnet#800
Command line arguments to run these changes
Links to issues or work items this PR addresses
The generated changes are supported by these changes: microsoftgraph/msgraph-sdk-dotnet-core#135