feature/hashmap import java removal#295
Merged
baywet merged 4 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom Sep 18, 2020
feature/hashmap-import-java-removalmicrosoftgraph/MSGraph-SDK-Code-Generator:feature/hashmap-import-java-removalCopy head branch name to clipboard
Merged
feature/hashmap import java removal#295baywet merged 4 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom feature/hashmap-import-java-removalmicrosoftgraph/MSGraph-SDK-Code-Generator:feature/hashmap-import-java-removalCopy head branch name to clipboard
baywet merged 4 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom
feature/hashmap-import-java-removalmicrosoftgraph/MSGraph-SDK-Code-Generator:feature/hashmap-import-java-removalCopy head branch name to clipboard
Conversation
zengin
approved these changes
Sep 18, 2020
| import com.google.gson.JsonElement; | ||
| import com.google.gson.annotations.SerializedName; | ||
| import com.google.gson.annotations.Expose; | ||
| <# if(((OdcmClass)c).IsOpen && !((OdcmClass)c).Properties.Any()) { #> |
Contributor
There was a problem hiding this comment.
nit: Looks like this is needed for AdditionalData. Consider leaving a comment on the relation between the import of HashMap and the condition.
Member
Author
There was a problem hiding this comment.
it's not for additional data but for open type with no properties (that are effectively hashmaps), things like PlannerChecklistItems for instance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removes unnecessary imports.
Generated code differences
microsoftgraph/msgraph-sdk-java#482