- adds missing navigation properties on composable functions in java#291
Merged
baywet merged 7 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom Sep 15, 2020
feature/composable-functions-properties-javamicrosoftgraph/MSGraph-SDK-Code-Generator:feature/composable-functions-properties-javaCopy head branch name to clipboard
Merged
- adds missing navigation properties on composable functions in java#291baywet merged 7 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom feature/composable-functions-properties-javamicrosoftgraph/MSGraph-SDK-Code-Generator:feature/composable-functions-properties-javaCopy head branch name to clipboard
baywet merged 7 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom
feature/composable-functions-properties-javamicrosoftgraph/MSGraph-SDK-Code-Generator:feature/composable-functions-properties-javaCopy head branch name to clipboard
Conversation
zengin
suggested changes
Sep 14, 2020
Contributor
zengin
left a comment
There was a problem hiding this comment.
Please consider improving the test data with composable functions as it seems that our current test metadata didn't have that.
.../TestDataJava/com/microsoft/graph/requests/extensions/IEntityType3ForwardRequestBuilder.java
Outdated
Show resolved
Hide resolved
.../TestDataJava/com/microsoft/graph/requests/extensions/IOnenotePageForwardRequestBuilder.java
Outdated
Show resolved
Hide resolved
Closed
3 tasks
Contributor
|
Thanks for investing time to improve the test data, really appreciate it. |
zengin
approved these changes
Sep 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composable functions allow to navigate to the return type's navigation properties and so on.
This PR adds missing navigation properties on composable functions
Generated code differences
microsoftgraph/msgraph-sdk-java#466
Command line arguments to run these changes
Provide the command line arguments here so that reviewers can quickly repro the results of changes.
Links to issues or work items this PR addresses