feature/java request interfaces inheritance#290
Merged
baywet merged 2 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom Sep 12, 2020
feature/java-request-interfaces-inheritancemicrosoftgraph/MSGraph-SDK-Code-Generator:feature/java-request-interfaces-inheritanceCopy head branch name to clipboard
Merged
feature/java request interfaces inheritance#290baywet merged 2 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom feature/java-request-interfaces-inheritancemicrosoftgraph/MSGraph-SDK-Code-Generator:feature/java-request-interfaces-inheritanceCopy head branch name to clipboard
baywet merged 2 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom
feature/java-request-interfaces-inheritancemicrosoftgraph/MSGraph-SDK-Code-Generator:feature/java-request-interfaces-inheritanceCopy head branch name to clipboard
Conversation
…ng casting from consummers
zengin
approved these changes
Sep 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the work to get batches working (microsoftgraph/msgraph-sdk-java#463) the fact that request interfaces do not inherit from IHttpRequest requires consumers to do dangerous casting to access the baserequest methods (and are implemented by the entity request class).
This removes the need for casting.
Generated code differences
microsoftgraph/msgraph-sdk-java@aa0b2c3
Command line arguments to run these changes
Provide the command line arguments here so that reviewers can quickly repro the results of changes.
Links to issues or work items this PR addresses