Nikithauc/typescript beta mainnamespace#288
Merged
nikithauc merged 4 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom Sep 10, 2020
nikithauc/typescript-beta-mainnamespacemicrosoftgraph/MSGraph-SDK-Code-Generator:nikithauc/typescript-beta-mainnamespaceCopy head branch name to clipboard
Merged
Nikithauc/typescript beta mainnamespace#288nikithauc merged 4 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom nikithauc/typescript-beta-mainnamespacemicrosoftgraph/MSGraph-SDK-Code-Generator:nikithauc/typescript-beta-mainnamespaceCopy head branch name to clipboard
nikithauc merged 4 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom
nikithauc/typescript-beta-mainnamespacemicrosoftgraph/MSGraph-SDK-Code-Generator:nikithauc/typescript-beta-mainnamespaceCopy head branch name to clipboard
Conversation
zengin
suggested changes
Sep 10, 2020
src/GraphODataTemplateWriter/CodeHelpers/TypeScript/TypeScriptNamespace.cs
Outdated
Show resolved
Hide resolved
src/GraphODataTemplateWriter/CodeHelpers/TypeScript/TypeScriptNamespace.cs
Outdated
Show resolved
Hide resolved
zengin
reviewed
Sep 10, 2020
| public string GetMainNamespace() | ||
| { | ||
| return TypeScriptMainNamespaceName; | ||
| return TypeScriptMainNamespaceNamePrefix + (ConfigurationService.Settings.Properties != null && ConfigurationService.Settings.Properties.ContainsKey("typescript.namespacePostfix") ? ConfigurationService.Settings.Properties["typescript.namespacePostfix"] : string.Empty); |
Contributor
There was a problem hiding this comment.
style: Please consider splitting this into multiple lines. And if you use null-conditional operator:
Suggested change
| return TypeScriptMainNamespaceNamePrefix + (ConfigurationService.Settings.Properties != null && ConfigurationService.Settings.Properties.ContainsKey("typescript.namespacePostfix") ? ConfigurationService.Settings.Properties["typescript.namespacePostfix"] : string.Empty); | |
| var properties = ConfigurationService.Settings?.Properties; | |
| return properties?.ContainsKey("typescript.namespacePostfix") == true | |
| ? TypeScriptMainNamespaceNamePrefix + properties["typescript.namespacePostfix"] | |
| : TypeScriptMainNamespaceNamePrefix; |
zengin
approved these changes
Sep 10, 2020
ddyett
reviewed
Sep 10, 2020
| // Arrange | ||
| var languageStr = language.ToString(); | ||
| var directoryPostfix = isPhpBeta ? "PHPBeta" : languageStr; | ||
| var directoryPostfix = languageStr + (isBeta ? "Beta" : string.Empty); |
There was a problem hiding this comment.
not sure if case sensitivity matters here but for php would languageStr be "PHP" so the string ends up exactly the same. Since it's a passed in parameter i don't know that's guaranteed and if it matters.
There was a problem hiding this comment.
i think this is answered looking at how it's called from the PHPMultipleNamespaces file.
Contributor
There was a problem hiding this comment.
This is fed from an enum that is local to the tests, so nobody will be able to change it by changing a string parameter somewhere. The test caller needs to specify an enum value.
Also this is only used as part of a directory name where case doesn't matter as long as you are on Windows :)
ddyett
approved these changes
Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For beta version, the typescript typings top-level namespace is 'microsoftgraphbeta'. The existing code has main namespaces always set to 'microsoftgraph'. This PR brings in the following changes-