Supports missing request body parameter#284
Merged
MIchaelMainer merged 2 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom Sep 8, 2020
MIchaelMainer/fixMethodRequestBodymicrosoftgraph/MSGraph-SDK-Code-Generator:MIchaelMainer/fixMethodRequestBodyCopy head branch name to clipboard
Merged
Supports missing request body parameter#284MIchaelMainer merged 2 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom MIchaelMainer/fixMethodRequestBodymicrosoftgraph/MSGraph-SDK-Code-Generator:MIchaelMainer/fixMethodRequestBodyCopy head branch name to clipboard
MIchaelMainer merged 2 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom
MIchaelMainer/fixMethodRequestBodymicrosoftgraph/MSGraph-SDK-Code-Generator:MIchaelMainer/fixMethodRequestBodyCopy head branch name to clipboard
Conversation
Discovered that reordered overloaded action, evaluateDynamicMembership exposed that we were only capturing parameters for the first overload. We need to capture all of the parameters which this commit fixes.
nikithauc
approved these changes
Sep 8, 2020
baywet
reviewed
Sep 8, 2020
| /// <returns>A deduplicated list of OdcmParameter.</returns> | ||
| public static List<OdcmParameter> WithDistinctParameters(this OdcmMethod odcmMethod) | ||
| { | ||
| var distinctMethods = odcmMethod.WithDistinctOverloads(); |
Member
There was a problem hiding this comment.
@MIchaelMainer I love it, building on what I added a couple of weeks ago ❤
baywet
approved these changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSDL reordering triggered this regression. Discovered that reordered overloaded action, evaluateDynamicMembership was missing a property. We were only capturing parameters for the first overload. We need to capture all of the parameters which this commit fixes.