Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@karrtikr
Copy link

For #4796

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests have been updated, please update or add tests

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #4813 into master will increase coverage by 1%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4813   +/-   ##
======================================
+ Coverage      62%     62%   +1%     
======================================
  Files         373     373           
  Lines       14706   14667   -39     
  Branches     1170    1162    -8     
======================================
+ Hits         9040    9070   +30     
+ Misses       5464    5395   -69     
  Partials      202     202

@karrtikr karrtikr merged commit 8f7cb40 into microsoft:master Mar 19, 2019
@karrtikr karrtikr deleted the reversebfs branch March 19, 2019 22:14
DonJayamanne pushed a commit that referenced this pull request Mar 20, 2019
* Generalize test results service

* News entry

* Fix gulp errors

* Updated status icons

* Added tests
DonJayamanne added a commit that referenced this pull request Mar 29, 2019
* Update tpn distro and 3rd party notices

* Pin to beta version of PTVSD (#4836)

Update version of PTVSD

* Add ignore button to the MacInterpreterSelectedAndNoOtherInterpreters… (#4808)

Add ignore button to the MacInterpreterSelectedAndNoOtherInterpretersDiagnostic & MacInterpreterSelectedAndHaveOtherInterpretersDiagnostic diagnostic message to provide the ability to opt out of the warning. (Fixing related issue #4448)

* Generalize test results service (#4813)

* Generalize test results service

* News entry

* Fix gulp errors

* Updated status icons

* Added tests

* fix names for run above and run below code lenses (#4879)

* Fix multiline comments with text on first line. (#4884)

* Cherry-pick 26a7b9c

* cherry pick from master branch

* Revert "Revert "Always use the same jedi environment (#4687)" (#4850)"

This reverts commit 0268ef4.

* Update change log entries

* Bump ptvsd to 4.2.5 (#4904)

* Bump version of PTVSD to 4.2.5
* Changes to capabilities

* Ensure output panel does not steal focus due to ls errors (#4919)

For #4868

<!--
  If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.:
    - [x] ~Has unit tests & system/integration tests~
-->
- [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
- [x] Title summarizes what is changing
- [x] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!)
- [n/a] Has sufficient logging.
- [n/a] Has telemetry for enhancements.
- [n/a] Unit tests & system/integration tests are added/updated
- [n/a] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate
- [n/a] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed)
- [n/a] The wiki is updated with any design decisions/details.

* Fix change log

* Bump pinned version of Language Server

* Release for march 2018 (#4931)

* New version
* Updated change log

* Same logic for stable and beta (#4964)

* Point release for March 2018 (#4965)

* Capture telemetry when tests are disabled (#4997)

For #4801

* Update change log
DonJayamanne added a commit that referenced this pull request Apr 4, 2019
* release:
  March 2019 point release with debugger fixes (#5056)
  Update change log
  Capture telemetry when tests are disabled (#4997)
  Point release for March 2018 (#4965)
  Same logic for stable and beta (#4964)
  Release for march 2018 (#4931)
  Bump pinned version of Language Server
  Fix change log
  Ensure output panel does not steal focus due to ls errors (#4919)
  Bump ptvsd to 4.2.5 (#4904)
  Update change log entries
  Revert "Revert "Always use the same jedi environment (#4687)" (#4850)"
  cherry pick from master branch
  Cherry-pick 26a7b9c
  Fix multiline comments with text on first line. (#4884)
  fix names for run above and run below code lenses (#4879)
  Generalize test results service (#4813)
  Add ignore button to the MacInterpreterSelectedAndNoOtherInterpreters… (#4808)
  Pin to beta version of PTVSD (#4836)
  Update tpn distro and 3rd party notices
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.