Ability to track the user selected Environment #25090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
May 20, 2025
| ): Promise< | ||
| | { | ||
| environment: EnvironmentPath; | ||
| reason: 'globalUserSelected' | 'workspaceUserSelected' | 'defaultRecommended'; |
There was a problem hiding this comment.
Providing the reasons why an environment is recommended.
DonJayamanne
commented
May 20, 2025
| @@ -28,6 +33,9 @@ export class PythonPathUpdaterService implements IPythonPathUpdaterServiceManage | ||
| let failed = false; | ||
| try { | ||
| await pythonPathUpdater.updatePythonPath(pythonPath); | ||
| if (trigger === 'ui') { |
There was a problem hiding this comment.
I believe this is the right spot for tracking what env is selected by the user.
DonJayamanne
commented
May 20, 2025
| @@ -67,7 +66,6 @@ export class InstallPackagesTool implements LanguageModelTool<IInstallPackageArg | ||
| for (const packageName of options.input.packageList) { | ||
| await installer.installModule(packageName, resourcePath, token, undefined, { installAsProcess: true }); | ||
| } | ||
| trackEnvUsedByTool(resourcePath, environment); |
There was a problem hiding this comment.
Old code no longer required
karthiknadig
previously approved these changes
May 20, 2025
rebornix
approved these changes
May 20, 2025
karthiknadig
approved these changes
May 20, 2025
anthonykim1
pushed a commit
to anthonykim1/vscode-python
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@karthiknadig /cc