Port Python Env Tools #25066
Port Python Env Tools #25066
Conversation
| "resourcePath" | ||
| ] | ||
| }, | ||
| "when": "!pythonEnvExtensionInstalled" |
There was a problem hiding this comment.
Will ensure these tools are disabled when Python Env extension is installed
src/client/extension.ts
Outdated
| @@ -162,6 +163,7 @@ async function activateUnsafe( | ||
| components.pythonEnvs, | ||
| ); | ||
| const proposedApi = buildProposedApi(components.pythonEnvs, ext.legacyIOC.serviceContainer); | ||
| registerTools(context,components.pythonEnvs, api.environments, ext.legacyIOC.serviceContainer); |
There was a problem hiding this comment.
Given these tools are temporary until Env extension goes stable, I didn't want to spend too much effort into moving these into the component registration, that was a lot of work, same with using Python API to get env details (there are too many ways to get env details, else resorted to using the external API as thats the stable way).
| env: CondaEnvInfo, | ||
| forShellExecution?: boolean, | ||
| ): Promise<string[] | undefined> { | ||
| const args = ['-p', env.prefix]; |
There was a problem hiding this comment.
Using -p as thats exactly whats done today in getRunPythonArgs,
See the method right above this.
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| export interface PipPackage { |
There was a problem hiding this comment.
Copied from Python Env repo
| * Returns a promise that rejects with an {@CancellationError} as soon as the passed token is cancelled. | ||
| * @see {@link raceCancellation} | ||
| */ | ||
| export function raceCancellationError<T>(promise: Promise<T>, token: CancellationToken): Promise<T> { |
There was a problem hiding this comment.
Couldn't move into async.ts as that doesn't allow usage of vscode types for some reason.
Left here for private use, again these will go away when env extension is stable.
| ourTools.add( | ||
| extensions.onDidChange(() => { | ||
| const envExtension = extensions.getExtension(ENVS_EXTENSION_ID); | ||
| if (envExtension) { |
There was a problem hiding this comment.
Check if env extension is installed and disable this.
| _token: CancellationToken, | ||
| ): Promise<PreparedToolInvocation> { | ||
| return { | ||
| invocationMessage: l10n.t('Fetching Python environment information'), |
There was a problem hiding this comment.
I will port these changes to prepareInvocation into the Python env extension soon
| : l10n.t(`Installing packages {0} in {1}`, options.input.packageList.sort().join(', '), envName); | ||
| } else { | ||
| title = | ||
| options.input.packageList.length === 1 |
There was a problem hiding this comment.
I will port these changes to prepareInvocation into the Python env extension soon
Uh oh!
There was an error while loading. Please reload this page.