Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[RFC] watch pyrefly settings #25041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions 22 src/client/languageServer/watcher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,34 +164,30 @@ export class LanguageServerWatcher implements IExtensionActivationService, ILang
// We only need to instantiate the language server once, even in multiroot workspace scenarios,
// so we only need one language server extension manager.
const key = this.getWorkspaceKey(resource, serverType);
const languageServer = this.workspaceLanguageServers.get(key);
if ((serverType === LanguageServerType.Node || serverType === LanguageServerType.None) && languageServer) {
logStartup(serverType, lsResource);
return languageServer;
let languageServer = this.workspaceLanguageServers.get(key);
if (!languageServer || serverType === LanguageServerType.Jedi || serverType === LanguageServerType.JediLSP) {
languageServer = this.createLanguageServer(serverType);
this.workspaceLanguageServers.set(key, languageServer);
}

// Instantiate the language server extension manager.
const languageServerExtensionManager = this.createLanguageServer(serverType);
this.workspaceLanguageServers.set(key, languageServerExtensionManager);

if (languageServerExtensionManager.canStartLanguageServer(interpreter)) {
if (languageServer.canStartLanguageServer(interpreter)) {
// Start the language server.
if (startupStopWatch) {
// It means that startup is triggering this code, track time it takes since startup to activate this code.
sendTelemetryEvent(EventName.LANGUAGE_SERVER_TRIGGER_TIME, startupStopWatch.elapsedTime, {
triggerTime: startupStopWatch.elapsedTime,
});
}
await languageServerExtensionManager.startLanguageServer(lsResource, interpreter);
await languageServer.startLanguageServer(lsResource, interpreter);

logStartup(languageServerType, lsResource);
this.languageServerType = languageServerType;
this.workspaceInterpreters.set(lsResource.fsPath, interpreter);
} else {
await languageServerExtensionManager.languageServerNotAvailable();
await languageServer.languageServerNotAvailable();
}

return languageServerExtensionManager;
return languageServer;
}

public async restartLanguageServers(): Promise<void> {
Expand Down Expand Up @@ -297,6 +293,8 @@ export class LanguageServerWatcher implements IExtensionActivationService, ILang
await this.refreshLanguageServer(resource);
} else if (event.affectsConfiguration(`python.analysis.pylanceLspClientEnabled`, resource)) {
await this.refreshLanguageServer(resource, /* forced */ true);
} else if (event.affectsConfiguration(`python.pyrefly.disableLanguageServices`, resource)) {
karthiknadig marked this conversation as resolved.
Show resolved Hide resolved
await this.refreshLanguageServer(resource);
}
});
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.