Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Retrigger discovery in background if some env has changed #14944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karrtikr merged 1 commit into from
Dec 14, 2020
Merged

Retrigger discovery in background if some env has changed #14944

karrtikr merged 1 commit into from
Dec 14, 2020

Conversation

@karrtikr
Copy link

@karrtikr karrtikr commented Dec 11, 2020 •
edited
Loading

Currently we're not making use of api.onChanged at all.

@karrtikr karrtikr added the no-changelog No news entry required label Dec 11, 2020
@karrtikr karrtikr requested review from karthiknadig and removed request for int19h December 11, 2020 00:20
@karrtikr karrtikr changed the title Retrigger discovery in background if something has changed Retrigger discovery in background if some env has changed Dec 11, 2020
ericsnowcurrently
ericsnowcurrently approved these changes Dec 14, 2020
View reviewed changes
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Good call, BTW.

@karrtikr karrtikr merged commit 7f0b0d4 into microsoft:main Dec 14, 2020
@karrtikr karrtikr deleted the useoncahnged branch December 14, 2020 17:40
karrtikr pushed a commit to karrtikr/vscode-python that referenced this pull request Dec 14, 2020
Retrigger discovery in background if something has changed (microsoft…
821675b 
…#14944)
karrtikr pushed a commit that referenced this pull request Dec 14, 2020
Retrigger discovery in background if something has changed (#14944)
07a8272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

+1 more reviewer

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karrtikr karrtikr

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karrtikr @ericsnowcurrently @karthiknadig
Morty Proxy This is a proxified and sanitized view of the page, visit original site.