Dispose webviewhost on panel load failure #13129
Conversation
|
Could continually repro this issue when trying to repro the save issue. Seems to be related to opening and closing a bunch of ipynbs when the extension is still in the act of loading. If it hits it could lock you out from ever being able to open up a file until vscode was closed down or reloaded. The "webview was disposed message" can still pop up. That seems to be coming from vscode and given our move to the new notebook editor I don't believe it's worth tracking down the root vscode cause. My fix here just prevents the "locked" state. That state was when the webpanel failed to load the host still existed and thought that it had a valid panel. So if you tried to reopen the file it would just try use the same panel and continually fail with the previous load promise. |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #13129 +/- ##
==========================================
- Coverage 59.79% 59.74% -0.06%
==========================================
Files 671 671
Lines 36681 36694 +13
Branches 5158 5156 -2
==========================================
- Hits 21933 21921 -12
- Misses 13655 13680 +25
Partials 1093 1093
Continue to review full report at Codecov.
|
For #13106
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).