Don't monkey patch vscode ext API #24103

New issue

Copy link

New issue

Copy link

Open

Open

Don't monkey patch vscode ext API#24103

Copy link

Labels

debtCovers everything internal: CI, testing, refactoring of the codebase, etc.Covers everything internal: CI, testing, refactoring of the codebase, etc.needs PRReady to be worked onReady to be worked on

Description

Tyriar

opened on Sep 12, 2024

Issue body actions

😱

vscode-python/src/client/common/application/terminalManager.ts

Lines 28 to 41 in 6578d9d

	/**
	* Monkeypatch the terminal to log commands sent.
	*/
	function monkeyPatchTerminal(terminal: Terminal) {
	if (!(terminal as any).isPatched) {
	const oldSendText = terminal.sendText.bind(terminal);
	terminal.sendText = (text: string, addNewLine: boolean = true) => {
	traceLog(`Send text to terminal: ${text}`);
	return oldSendText(text, addNewLine);
	};
	(terminal as any).isPatched = true;
	}
	return terminal;
	}

Metadata

Metadata

Assignees

No one assigned

Labels

debtCovers everything internal: CI, testing, refactoring of the codebase, etc.Covers everything internal: CI, testing, refactoring of the codebase, etc.needs PRReady to be worked onReady to be worked on

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions