Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use an enum for OS Types #2238

Copy link
Copy link
@DonJayamanne

Description

@DonJayamanne
Issue body actions

Current we use boolean values to determine whether os is one of Mac, Windows or Linux.
Should consider using an Enum.
This could result in a number of changes, however I believe it is worth, and needs to be done.
Using 3 booleans doesn't work well, when all of them are mutually exclusive.

Suggestion:

export enum OS {
	Linux = 'Linux',
	Mac = 'Mac',
	Windows = 'Windows'
}

@Microsoft/pvsc-team

d3r3kk

Metadata

Metadata

Assignees

No one assigned

    Labels

    debtCovers everything internal: CI, testing, refactoring of the codebase, etc.Covers everything internal: CI, testing, refactoring of the codebase, etc.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.