Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: make review.openLocalFile support triggering from the keyboard. #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexr00 merged 1 commit into from
Mar 18, 2024
Merged

fix: make review.openLocalFile support triggering from the keyboard. #5840

alexr00 merged 1 commit into from
Mar 18, 2024

Conversation

@ipcjs
Copy link
Contributor

@ipcjs ipcjs commented Mar 18, 2024

After configuring a keyboard shortcut for the review.openLocalFile command, triggering the keyboard shortcut will report the following error:

2024-03-18 14:43:41.194 [error] TypeError: Cannot read properties of undefined (reading 'query')
	at /Users/ipcjs/.vscode/extensions/github.vscode-pull-request-github-0.82.0/dist/extension.js:2024:1200
	at l.h (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:150:184839)
	at l.$executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:150:185699)

This PR fixes this issue.

@alexr00 alexr00 added this to the March 2024 milestone Mar 18, 2024
alexr00
alexr00 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@alexr00 alexr00 enabled auto-merge (squash) March 18, 2024 08:59
@alexr00 alexr00 merged commit cc56054 into microsoft:main Mar 18, 2024
@ipcjs ipcjs deleted the pr-openLocalFile-keybinds branch March 18, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandy081 sandy081 sandy081 approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

March 2024

Development

Successfully merging this pull request may close these issues.

3 participants

@ipcjs @sandy081 @alexr00
Morty Proxy This is a proxified and sanitized view of the page, visit original site.