Generated code suggestion can't be applied to the file correctly #6171
Description
Testing #6160
Initial code
preserveElements(indexes: number[]): void {
this.preservedItems.clear();
for (const index of indexes) {
if (index >= 0 && index < this.items.length) {
const item = this.items[index];
this.preservedItems.add(item);
if (!item.row) {
this.insertItemInDOM(index);
}
this.updateItemInDOM(item, index);
}
}
}new code
preserveElements(indexes: number[]): void {
this.preservedItems.clear();
let updatePreservedElements = false;
for (const index of indexes) {
if (index >= 0 && index < this.items.length) {
const item = this.items[index];
this.preservedItems.add(item);
if (!item.row) {
this.insertItemInDOM(index);
updatePreservedElements = true;
}
this.updateItemInDOM(item, index);
}
}
if (updatePreservedElements) {
this.rerender();
}
}The generated code suggestion
let updatePreservedElements = false;
for (const index of indexes) {
if (index >= 0 && index < this.items.length) {
const item = this.items[index];
this.preservedItems.add(item);
if (!item.row) {
this.insertItemInDOM(index);
updatePreservedElements = true;
}
}
}
if (updatePreservedElements) {
this.rerender();
} However when applied to the editor, the file was in a broken state
Metadata
Metadata
Assignees
Labels
Issue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug