fix: avoid dispose unmatched handlers #1614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaeumer
previously approved these changes
Feb 18, 2025
Member
|
Nice work |
alexr00
previously approved these changes
Feb 18, 2025
Contributor
Author
|
Forgot to have star handlers included |
Contributor
Author
|
@microsoft-github-policy-service agree |
dbaeumer
approved these changes
Feb 19, 2025
alexr00
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple handlers with the same type is registered for json rpc request/notification/progress, only the last handler will be kept. However, calls of previous registration's returned disposable will unexpectedly remove the registered handler.