Add support for CompletionList "applyKind" to control how defaults and per-item commitCharacters/data are combined #1558
Conversation
…d per-item commitCharacters/data are combined Implements the changes in the LSP spec PR at microsoft/language-server-protocol#2018. (Also see microsoft/language-server-protocol#1802)
|
@dbaeumer FYI in case you didn't see this :) Looks like one of the status checks is stuck too (not the approval one, but |
|
I was out the last 1 1/2 weeks. Will have a look this week. |
| * | ||
| * @since 3.18.0 | ||
| */ | ||
| export namespace ApplyKind { |
There was a problem hiding this comment.
I missed that on the spec side. Usually we only use string enums for enum kinds that are extensible from the server side and then type them as strings. To make things consistent I would say we should use numbers instead.
There was a problem hiding this comment.
Sure - I've pushed f8ed433 + 5e28745 with this change and some minor tweaks, and equiv changes in microsoft/language-server-protocol#2018
|
@dbaeumer thanks! Are you planning a new |
|
@DanTup yes, will do one beginning of endgame week. |
Implements the changes in the LSP spec PR at microsoft/language-server-protocol#2018 (see also microsoft/language-server-protocol#1802).
Please let me know if you think there are any additional test cases that need covering.