Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@cadamini
Copy link
Contributor

@cadamini cadamini commented May 22, 2023

Fixes #6312

I spent some time figuring out how the locked editor groups feature is working after reading the release notes docs linked in the referenced issue.

This PR adds some information to the docs. I hope this help as the basis for the final update.

FYI @gjsjohnmurray

docs/getstarted/userinterface.md Outdated Show resolved Hide resolved
docs/getstarted/userinterface.md Show resolved Hide resolved
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. I have made a few suggestions.

docs/getstarted/userinterface.md Outdated Show resolved Hide resolved
docs/getstarted/userinterface.md Outdated Show resolved Hide resolved
docs/getstarted/userinterface.md Outdated Show resolved Hide resolved
docs/getstarted/userinterface.md Outdated Show resolved Hide resolved
Co-authored-by: John Murray <johnm@georgejames.com>
docs/getstarted/userinterface.md Outdated Show resolved Hide resolved
docs/getstarted/userinterface.md Outdated Show resolved Hide resolved
docs/getstarted/userinterface.md Outdated Show resolved Hide resolved

Terminals are configured by default to cause a new group to lock automatically. A lock icon in the action toolbar (top right) indicates a locked group. The locked state of an editor group is persisted and restored across restarts.

<!-- Required? Locked editor https://code.visualstudio.com/assets/updates/1_61/editor-readonly-deleted.png -->
Copy link
Contributor Author

@cadamini cadamini May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still open. If needed, can someone move the images to the correct location and create the image link?

Otherwise

Suggested change
<!-- Required? Locked editor https://code.visualstudio.com/assets/updates/1_61/editor-readonly-deleted.png -->


You can also lock empty groups for a more stable editor layout. With setting `workbench.editor.closeEmptyGroups` you can control whether an empty group is closed when the last tab in a group is closed. When disabled, empty groups will remain part of the grid.

<!-- Required? Lock group option in overflow menu https://code.visualstudio.com/assets/updates/1_60/locked-editor-group.png -->
Copy link
Contributor Author

@cadamini cadamini May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still open. If needed, can someone move the images to the correct location and create the image link?

Otherwise

Suggested change
<!-- Required? Lock group option in overflow menu https://code.visualstudio.com/assets/updates/1_60/locked-editor-group.png -->

@cadamini
Copy link
Contributor Author

cadamini commented Jun 7, 2023

Please let me know what to do with my open suggestions. FYI - Not sure how to get this merged. I will close my PR in a week.

@gjsjohnmurray
Copy link
Contributor

Pinging @gregvanl

@gregvanl
Copy link

gregvanl commented Jun 9, 2023

@cadamini Thank you for your continued interest in the VS Code documentation and apologies for the delay in reviewing this PR.

I'm reluctant to add a description of this feature to the docs/getstarted/userinterface topic since we want to be careful not to overwhelm new users with advanced features. Per the discussion in microsoft/vscode#182294, this was added mostly to handle terminal editors and could be confusing to new users.

I think issues #6312, #6313, and #6326 make the case for a new topic on advanced editor features.

Closing this PR for now and we may be able to fold in this content into a new "Advanced Editor" topic

@gregvanl gregvanl closed this Jun 9, 2023
@cadamini cadamini deleted the add-locked-editor-groups branch June 9, 2023 20:43
@cadamini
Copy link
Contributor Author

Do you have already someone in mind who could start the advanced editor features article?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Locked Editor Groups feature is only documented in release notes

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.