Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@EbXpJ6bp
Copy link
Contributor

@EbXpJ6bp EbXpJ6bp commented Jun 17, 2018

Hi.
This PR makes a couple of minor changes to extension editor.

  • maintain image's aspect ratio
  • no wrapping of table title by character
before after
1 2
3 4

Copy link
Contributor

@ramya-rao-a ramya-rao-a Jun 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the need for object-fit but not for the change in height/width.

The change in the height and width will make the image bigger and make it look like there is no padding/margin between various dependencies

screen shot 2018-06-23 at 12 30 54 pm

In your particular example of azure account, I would suggest to log an issue in the repository for that extension, to use a better image

* maintain image's aspect ratio
* no wrapping of table title by character
@EbXpJ6bp
Copy link
Contributor Author

Thank you for the reply.
I changed it!

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ramya-rao-a ramya-rao-a changed the title Improve Extension editor UI Improve Dependencies and Contributions UI in the Extension editor Jun 24, 2018
@ramya-rao-a ramya-rao-a added this to the June 2018 milestone Jun 24, 2018
@ramya-rao-a ramya-rao-a merged commit 4ae06bd into microsoft:master Jun 24, 2018
@EbXpJ6bp EbXpJ6bp deleted the patch-2 branch June 26, 2018 11:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.