Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Hirse
Copy link
Contributor

@Hirse Hirse commented Jun 3, 2018

See microsoft/vscode-eslint#473
@aeschli, @dbaeumer
This only adds the Ignore-language and assigns it to .gitignore.
I would like to add a reference to it in extensions/npm for .npmignore. Is it possible to add that file association as contribution in the package.json or how would you propose to do it?

@octref octref requested a review from aeschli June 4, 2018 05:17
@aeschli
Copy link
Contributor

aeschli commented Jun 4, 2018

That looks good. I'd suggest to give it id gitignore even if it is now used in many other contexts.
I'll make that change...
Thinking more about it, 'ignore' is fine as id.

@aeschli aeschli merged commit 439ac99 into microsoft:master Jun 4, 2018
@aeschli aeschli added this to the June 2018 milestone Jun 4, 2018
@aeschli
Copy link
Contributor

aeschli commented Jun 4, 2018

I added support for npmignore, see the change set.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.