fix: use childNodes instead of children in DOM.reset for markdown rendering. Fix #266103 #276890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in markdown rendering where text nodes were being lost when a target element was provided. The issue occurred because the code was using .children (which only returns element nodes) instead of .childNodes (which returns all nodes including text).
- Changed
DOM.reset(target, ...renderedContent.children)to usechildNodesinstead ofchildren
mjbvz
approved these changes
Nov 12, 2025
Collaborator
mjbvz
left a comment
There was a problem hiding this comment.
Thanks! Makes sense since our sanitizer converts the html to normal text nodes
roblourens
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: use childNodes instead of children in DOM.reset for markdown rendering. Fix #266103
Might be related to #273617.
Before:
After:
CC: @mjbvz