Hi, I have tested my PR within codespaces' VNC, it does work now.

I had to enable supportHtml to wrap with <code> though, so you may want to check if another input could inject links/html.

Prompt input sometimes gets an extra space appended.

There might be a desync causing this, needs more investigation. As I started that comment, it is out of topic.

Thanks for the PR. Can you pls provide a screenshot of this working for you in testing?

Update:

Prefixing backslashes to backticks makes them show up again.
However, I think I'll have to escape most of the markdown characters because I can still escape things out:

I'll also check if just applying db999f4 onto main works.

I will send the patch in after also testing with links with titles, but here is how it looks right now:

If there is any other markdown escapes you would like me to check, I'll happily test but for now I changed the code to:

1. If there are any < or >, which could cause html injections, they are replaced with < and >.
2. If there is a markdown link, the link part gets wrapped with < and >, as escaping in step 3 will add a ) to the link's end.
3. Escape [, ], (, ), -, *, !, # and ` characters by prefixing with backslashes, as markdown renderer doesn't skip markdown in <code> elements. (Maybe sub-issue?)

I will send the patch in after also testing with links with titles

I have tested (https://regexr.com/8hu9f) and it should be good for now.

Testing with this input:

echo `date`; echo </code>[escaped link?](https://youtu.be/dQw4w9WgXcQ "asdasdasd")

Main Branch (124710c)

My patch (3ccfea3)

I'll also check if just applying db999f4 onto main works.

It does not. Until someone confirms that markdown rendering inside <code> is a bug and gets that fixed, this seems like the best solution.

If I didn't misread the code when I first opened this issue/PR, the changes I made should run once per keystroke, so it should -hopefully- have only negligible performance impacts.

I guess feature release from Github Universe could have created some urgent backlog but is there anything blocking this PR from being reviewed?

Edit: Well, the Monthly Endgame has started. Oh well.

Hello @meganrogge, while waiting for this PR to get reviewed, should I update the base branch to test against newer base or should I leave as is?

I'm asking this in general, it's not mentioned in contributing guide.

@Abrifq let me know if you're able to break this one, but I think it's solid

@Abrifq let me know if you're able to break this one, but I think it's solid

Sorry, I just became available to check, I will update but this feels weird on UX.

There is an even simpler version, I will make a new PR on top of this one.

@@ -109,15 +109,8 @@ export function refreshShellIntegrationInfoStatus(instance: ITerminalInstance) {
 	}
 	const combinedString = instance.capabilities.get(TerminalCapability.CommandDetection)?.promptInputModel.getCombinedString();
 	if (combinedString !== undefined) {
-		if (combinedString.includes('`')) {
-			detailedAdditions.push('Prompt input:' + [
-				'```',
-				combinedString, // No new lines so no need to escape ```
-				'```',
-			].map(e => `\n    ${e}`).join(''));
-		} else {
-			detailedAdditions.push(`Prompt input: \`${combinedString.replaceAll('`', '`')}\``);
-		}
+		// Wrap with triple backticks so that single backticks can show up (command substitution in bash uses backticks, for example)
+		detailedAdditions.push(`Prompt input: \`\`\`${combinedString}\`\`\``);
 	}
 	const detailedAdditionsString = detailedAdditions.length > 0
 		? '\n\n' + detailedAdditions.map(e => `- ${e}`).join('\n')

#272425 (comment)
The simplest solution will be only wrapping with triple backticks and assume the user is not writing markdown in command line.

Using two backticks in a row is pretty much useless as it just makes an empty string.

Well, that's the simplest, the cleaner solution would be either adding some if not all css properties of <code> to <pre> or to tweak markdown string implementation (and usage) to append/add another instance of markdown string w/o changing the props of the parent one.

@Abrifq we definitely don't want to support HTML there. I also don't want to get into trying to change the markdown rendering. Again this is just debug info that's hidden by default, handling all edge cases perfectly isn't too important.