fix: tiny memory leak in debugToolBar.ts #259349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @deepak1556 |
DonJayamanne
previously approved these changes
Aug 4, 2025
Contributor
Author
|
@microsoft-github-policy-service agree company="Anysphere" |
Contributor
Author
|
@connor4312 thanks for the review - i removed unused imports to address the hygiene concerns, so it looks like i need another approval. |
`dispose(IDisposable[])` call disposes every element of the array but does not clear the array itself - but it returns an empty array. As a result `debugViewTitleItems` array accumulates all items and keep references to them forever. There are two potential solutions: - `debugViewTitleItems = dispose(debugViewTitleItems)` - use DisposableStore This commit implements the second one.
9b10b67 to
402a4fd
Compare
connor4312
approved these changes
Aug 4, 2025
dbaeumer
approved these changes
Aug 4, 2025
bpasero
reviewed
Aug 4, 2025
| // Debug toolbar | ||
|
|
||
| const debugViewTitleItems: IDisposable[] = []; | ||
| const debugViewTitleItems = new DisposableStore(); |
Member
There was a problem hiding this comment.
Small nit: this should be marked as singleton as well because it never gets disposed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dispose(IDisposable[])call disposes every element of the array but does not clear the array itself - but it returns an empty array. As a resultdebugViewTitleItemsarray accumulates all items and keep references to them forever.There are two potential solutions:
debugViewTitleItems = dispose(debugViewTitleItems)This commit implements the second one.