Want to note that the copyOnSelection event seems overly aggressive. Here is another test case which seems to be problematic, though it doesn't have a clear causation or solution.

I will attempt to provide a solution for this under a separate PR. Figured it might be worth including here too as someone reviewing the PR might have some insight.

1. Open a terminal and open the FindWidget with ctrl+f
2. Search for some text that exists in the terminal, such as "some text". The text "some text" is copied to the clipboard
3. Focus away from the terminal and copy some "other text" to the clipboard
4. Focus back on the terminal.
5. Press any key to enter a character into the terminal.
   • Alternatively use ctrl+f to paste into the terminal.
6. Use ctrl+f to paste into the terminal. The searched text copied to the clipboard in step 2 is pasted.
   • Expect: "other text"
   • Get: "some text"

It appears the rendering done as a result of step 5 includes calling the onSelectionChanged event which overwrites the clipboard unexpectedly.

Is there anything I can/need to do to get movement on this?

Hi @kenherring Thanks much for looking into this!

I'm not quite getting the difference between the first test case in this PR vs. the second test case.

Is the difference just that you are doing Press any key to enter a character into the terminal. instead of straight up doing ctrl+f in one of the steps?

@anthonykim1 You are correct. The first test case, which is resolved by this PR, involves using ctrl+f to open or access the find widget. This overwrites the clipboard.

The second test case is not addressed by this PR and involves entering any key to add text to the terminal, which overwrites the clipboard when the added text causes a redrawing of the terminal. This does not have as clear of a solution and is something I'll be willing to dig deeper on in a future PR.

Make sense, @kenherring Yeah, I think we should address that(the case you just mentioned) as well?? unless its expected behavior @Tyriar

It seems like what is happening with that second case (after 'copying from clipboard'), and typing in terminal is that those selection triggered from the previous ctrl+f gets selected again and shows the blinks as well.

This PR is still improvement as it prevents terminal find from overwriting more recent copy and paste from the editor when ctrl+f is triggered right away after clipboard from editor.

Before this PR:

After this PR: