Initialize test variables in setup to avoid order dependency.
#226596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncy. Some test cases reassing `results`, and when it is only initialized in the body of `suite` instead of in `setup`, a different ordering of test cases makes the test fail. The goal is for each test case to be independent of the others, so that they could be executed in any order. This test already uses setup for other variables, so I am assuming it was just an oversight not to have done this for `results`.
amunger
approved these changes
Aug 30, 2024
bpasero
approved these changes
Aug 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test cases reassign
results, and when it is only initialized in the body ofsuiteinstead of insetup, a different ordering of test cases makes the test fail. The goal is for each test case to be independent of the others, so that they could be executed in any order. This test already uses setup for other variables, so I am assuming it was just an oversight not to have done this forresults.Fixes #226595.