Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few event listener memory leaks in the debug view:
elementDisposablesandtemplateDisposablesseparately to clear element event listeners when an element is disposed and template event listeners when the template is disposedIDisposableArray to aDisposableStore(not really necessary but it seemed easier to work with aDisposableStore)Before
The number of event listeners when debugging a javascript file 17 times grows from 3220 to 9936:
After
The number of event listeners when debugging a javascript file 17 times grows from 2499 to 3731:
The number leaking event listeners seems to be ~80% less in this case. Nevertheless, it seems likely that are still additional memory leaks since the number of event listeners is still growing.